[INFO] cloning repository https://github.com/ember-research-lab/vetpkg
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ember-research-lab/vetpkg" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fember-research-lab%2Fvetpkg", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fember-research-lab%2Fvetpkg'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 74f03c1381ad233a97e0ad27e9c585b5667dd911
[INFO] fixing ember-research-lab/vetpkg against try#622891a4e29178280638a6b63a8908bde2c0c854+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817-2
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fember-research-lab%2Fvetpkg" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/ember-research-lab/vetpkg
[INFO] finished tweaking git repo https://github.com/ember-research-lab/vetpkg
[INFO] tweaked toml for git repo https://github.com/ember-research-lab/vetpkg written to /workspace/builds/worker-5-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/ember-research-lab/vetpkg on toolchain 622891a4e29178280638a6b63a8908bde2c0c854
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/ember-research-lab/vetpkg already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3a6becf2bc8dde7f3fa57ede90e4f284e72d296796fc446bbb1e2c7cc0530151" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 2a5f898c1400feeaf8e1be4e917e62eb01d4c6ba4980ab62da78526b29caba27
[INFO] running `Command { std: "docker" "start" "2a5f898c1400feeaf8e1be4e917e62eb01d4c6ba4980ab62da78526b29caba27", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "2a5f898c1400feeaf8e1be4e917e62eb01d4c6ba4980ab62da78526b29caba27" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "2a5f898c1400feeaf8e1be4e917e62eb01d4c6ba4980ab62da78526b29caba27", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "2a5f898c1400feeaf8e1be4e917e62eb01d4c6ba4980ab62da78526b29caba27" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }`
[INFO] [stderr] crater-edition-check: migrating to next edition
[INFO] [stderr]    Migrating Cargo.toml from 2021 edition to 2024
[INFO] [stderr]     Checking vetpkg v0.3.0 (/opt/rustwide/workdir)
[INFO] [stderr]    Migrating src/lib.rs from 2021 edition to 2024
[INFO] [stderr]        Fixed src/correlation/indexes.rs (3 fixes)
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]   --> src/engine/suspicion_map.rs:88:40
[INFO] [stdout]    |
[INFO] [stdout] 88 |                 if let Ok(mut guard) = inner.write() {
[INFO] [stdout]    |                           ---------    ^^^^^^^^^^^^^
[INFO] [stdout]    |                           |            |
[INFO] [stdout]    |                           |            this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]    |                           |            up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout]    |                           `guard` calls a custom destructor
[INFO] [stdout]    |                           `guard` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 91 |             }
[INFO] [stdout]    |             - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]    |
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/poison/rwlock.rs:1128:0
[INFO] [stdout] note: `guard` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/poison/rwlock.rs:1128:0
[INFO] [stdout]    = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]    = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> src/net/proxy.rs:111:15
[INFO] [stdout]     |
[INFO] [stdout] 111 |           match listener.accept() {
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |                 |
[INFO] [stdout]     |                 this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                 up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] 112 |               Ok((stream, _)) => {
[INFO] [stdout]     |                   ------
[INFO] [stdout]     |                   |
[INFO] [stdout]     |                   `stream` calls a custom destructor
[INFO] [stdout]     |                   `stream` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 119 | /                 thread::spawn(move || {
[INFO] [stdout] 120 | |                     let _permit = permit;
[INFO] [stdout] 121 | |                     let _ = handle_connection(stream, &ctx, &stop);
[INFO] [stdout] 122 | |                 });
[INFO] [stdout]     | |                  -
[INFO] [stdout]     | |                  |
[INFO] [stdout]     | |__________________this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |                    `#1` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 131 |       }
[INFO] [stdout]     |       - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `stream` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/thread/lifecycle.rs:171:0
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sys/thread/unix.rs:140:0
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]        Fixed src/net/http_client.rs (2 fixes)
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]   --> src/engine/suspicion_map.rs:88:40
[INFO] [stdout]    |
[INFO] [stdout] 88 |                 if let Ok(mut guard) = inner.write() {
[INFO] [stdout]    |                           ---------    ^^^^^^^^^^^^^
[INFO] [stdout]    |                           |            |
[INFO] [stdout]    |                           |            this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]    |                           |            up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout]    |                           `guard` calls a custom destructor
[INFO] [stdout]    |                           `guard` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 91 |             }
[INFO] [stdout]    |             - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]    |
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/poison/rwlock.rs:1128:0
[INFO] [stdout] note: `guard` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/poison/rwlock.rs:1128:0
[INFO] [stdout]    = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]    = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Migrating tests/phase4_correlation.rs from 2021 edition to 2024
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> src/net/proxy.rs:111:15
[INFO] [stdout]     |
[INFO] [stdout] 111 |           match listener.accept() {
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |                 |
[INFO] [stdout]     |                 this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                 up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] 112 |               Ok((stream, _)) => {
[INFO] [stdout]     |                   ------
[INFO] [stdout]     |                   |
[INFO] [stdout]     |                   `stream` calls a custom destructor
[INFO] [stdout]     |                   `stream` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 119 | /                 thread::spawn(move || {
[INFO] [stdout] 120 | |                     let _permit = permit;
[INFO] [stdout] 121 | |                     let _ = handle_connection(stream, &ctx, &stop);
[INFO] [stdout] 122 | |                 });
[INFO] [stdout]     | |                  -
[INFO] [stdout]     | |                  |
[INFO] [stdout]     | |__________________this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |                    `#1` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 131 |       }
[INFO] [stdout]     |       - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `stream` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/thread/lifecycle.rs:171:0
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sys/thread/unix.rs:140:0
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]        Fixed src/store/findings_log.rs (3 fixes)
[INFO] [stderr]    Migrating tests/phase6_audit_ci_online.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/phase1_dep_age.rs from 2021 edition to 2024
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]   --> tests/phase6_audit_ci_online.rs:38:19
[INFO] [stdout]    |
[INFO] [stdout] 38 |               match listener.accept() {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]    |                     up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] 39 |                   Ok((mut s, _)) => {
[INFO] [stdout]    |                       -----
[INFO] [stdout]    |                       |
[INFO] [stdout]    |                       `s` calls a custom destructor
[INFO] [stdout]    |                       `s` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 49 |                       let (status, body) = responses2
[INFO] [stdout]    |  __________________________________________-
[INFO] [stdout] 50 | |                         .lock()
[INFO] [stdout] 51 | |                         .unwrap()
[INFO] [stdout]    | |                                 -
[INFO] [stdout]    | |                                 |
[INFO] [stdout]    | |_________________________________this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]    |                                   `#1` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 71 |           });
[INFO] [stdout]    |           - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]    |
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `s` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/poison/mutex.rs:741:0
[INFO] [stdout]    = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]    = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]   --> tests/phase1_dep_age.rs:36:19
[INFO] [stdout]    |
[INFO] [stdout] 36 |             match listener.accept() {
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |                   |
[INFO] [stdout]    |                   this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]    |                   up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] 37 |                 Ok((mut s, _)) => {
[INFO] [stdout]    |                     -----
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     `s` calls a custom destructor
[INFO] [stdout]    |                     `s` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 51 |                         fetch_log2.lock().unwrap().push(p.clone());
[INFO] [stdout]    |                         --------------------------
[INFO] [stdout]    |                         |
[INFO] [stdout]    |                         this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]    |                         `#1` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 72 |         });
[INFO] [stdout]    |         - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]    |
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `s` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/poison/mutex.rs:741:0
[INFO] [stdout]    = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]    = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Migrating tests/phase0_compression.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/attack_matrix.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/phase1_audit.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating src/main.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/phase6_tier2_escalation.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/phase3_fp_suite.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/threat_intel_fixtures.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/phase0_integration.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/phase2_streaming.rs from 2021 edition to 2024
[INFO] [stderr]        Fixed tests/phase0_integration.rs (2 fixes)
[INFO] [stderr]        Fixed tests/phase2_streaming.rs (2 fixes)
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]   --> tests/phase2_streaming.rs:39:15
[INFO] [stdout]    |
[INFO] [stdout] 39 |         match listener.accept() {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |               |
[INFO] [stdout]    |               this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]    |               up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] 40 |             Ok((mut s, _)) => {
[INFO] [stdout]    |                 -----
[INFO] [stdout]    |                 |
[INFO] [stdout]    |                 `s` calls a custom destructor
[INFO] [stdout]    |                 `s` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 59 |     });
[INFO] [stdout]    |     - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]    |
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `s` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout]    = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]    = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Migrating tests/phase4_fp_50.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/phase5_audit_ci.rs from 2021 edition to 2024
[INFO] [stderr]    Migrating tests/phase6_proxy_e2e.rs from 2021 edition to 2024
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]    --> tests/phase6_proxy_e2e.rs:88:19
[INFO] [stdout]     |
[INFO] [stdout]  88 |               match listener.accept() {
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |                     |
[INFO] [stdout]     |                     this value will be stored in a temporary; let us call it `#2`
[INFO] [stdout]     |                     up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout]  89 |                   Ok((mut s, _)) => {
[INFO] [stdout]     |                       -----
[INFO] [stdout]     |                       |
[INFO] [stdout]     |                       `s` calls a custom destructor
[INFO] [stdout]     |                       `s` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 100 |                       let (status, body, ctype) = responses2
[INFO] [stdout]     |  _________________________________________________-
[INFO] [stdout] 101 | |                         .lock()
[INFO] [stdout] 102 | |                         .unwrap()
[INFO] [stdout]     | |                                 -
[INFO] [stdout]     | |                                 |
[INFO] [stdout]     | |_________________________________this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]     |                                   `#1` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 122 |           });
[INFO] [stdout]     |           - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]     |
[INFO] [stdout] note: `#2` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `s` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]    --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sync/poison/mutex.rs:741:0
[INFO] [stdout]     = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]     = warning: this changes meaning in Rust 2024
[INFO] [stdout]     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]     = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Migrating tests/phase1_osv.rs from 2021 edition to 2024
[INFO] [stdout] warning: relative drop order changing in Rust 2024
[INFO] [stdout]   --> tests/phase1_osv.rs:34:19
[INFO] [stdout]    |
[INFO] [stdout] 34 |             match listener.accept() {
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |                   |
[INFO] [stdout]    |                   this value will be stored in a temporary; let us call it `#1`
[INFO] [stdout]    |                   up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024
[INFO] [stdout] 35 |                 Ok((mut s, _)) => {
[INFO] [stdout]    |                     -----
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     `s` calls a custom destructor
[INFO] [stdout]    |                     `s` will be dropped later as of Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 60 |         });
[INFO] [stdout]    |         - now the temporary value is dropped here, before the local variables in the block or statement
[INFO] [stdout]    |
[INFO] [stdout] note: `#1` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout] note: `s` invokes this custom destructor
[INFO] [stdout]   --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0
[INFO] [stdout]    = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages
[INFO] [stdout]    = warning: this changes meaning in Rust 2024
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/temporary-tail-expr-scope.html>
[INFO] [stdout]    = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.14s
[INFO] [stderr] crater-edition-check: vetpkg v0.3.0 (/opt/rustwide/workdir) updating edition from 2021 to 2024
[INFO] [stderr]     Checking vetpkg v0.3.0 (/opt/rustwide/workdir)
[INFO] [stdout] error: usage of an `unsafe` block
[INFO] [stdout]    --> src/net/http_client.rs:466:9
[INFO] [stdout]     |
[INFO] [stdout] 466 |         unsafe { std::env::set_var("VETPKG_NO_EXTERNAL_NETWORK", "1") };
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the lint level is defined here
[INFO] [stdout]    --> src/lib.rs:1:11
[INFO] [stdout]     |
[INFO] [stdout]   1 | #![forbid(unsafe_code)]
[INFO] [stdout]     |           ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: usage of an `unsafe` block
[INFO] [stdout]    --> src/net/http_client.rs:469:9
[INFO] [stdout]     |
[INFO] [stdout] 469 |         unsafe { std::env::remove_var("VETPKG_NO_EXTERNAL_NETWORK") };
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: usage of an `unsafe` block
[INFO] [stdout]    --> src/store/findings_log.rs:137:9
[INFO] [stdout]     |
[INFO] [stdout] 137 |         unsafe { std::env::set_var("HOME", td.path()) };
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: usage of an `unsafe` block
[INFO] [stdout]    --> src/store/findings_log.rs:166:13
[INFO] [stdout]     |
[INFO] [stdout] 166 |             unsafe { std::env::set_var("HOME", p) };
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: usage of an `unsafe` block
[INFO] [stdout]    --> src/store/findings_log.rs:169:13
[INFO] [stdout]     |
[INFO] [stdout] 169 |             unsafe { std::env::remove_var("HOME") };
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `vetpkg` (lib test) due to 5 previous errors
[INFO] running `Command { std: "docker" "inspect" "2a5f898c1400feeaf8e1be4e917e62eb01d4c6ba4980ab62da78526b29caba27", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "2a5f898c1400feeaf8e1be4e917e62eb01d4c6ba4980ab62da78526b29caba27", kill_on_drop: false }`
[INFO] [stdout] 2a5f898c1400feeaf8e1be4e917e62eb01d4c6ba4980ab62da78526b29caba27
